Open
Conversation
IgnaceBleukx
approved these changes
Apr 6, 2026
Collaborator
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Great, that should do away with a lot of weird cases in the transformation stack...
Maybe also add the optional argument to expressions.utils.implies? We use it when we're not sure the lhs is an expression
| def deepcopy(self, memodict={}): | ||
| """ DEPRECATED: use copy.deepcopy() instead | ||
|
|
||
| Will be removed in stable version. |
Collaborator
There was a problem hiding this comment.
Could probably be removed by now... We'll do a major release next time anyway
| """Implication constraint: ``self -> other``. | ||
|
|
||
| Python does not offer relevant syntax for implication, call this method instead. | ||
| For double implication, use equivalence ``self == other``. |
|
|
||
| Args: | ||
| other (ExprLike): the right-hand-side of the implication | ||
| simplify (bool): if True, simplify True/False constants (might remove expressions & there variables from user-view) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one notable change is about 'implies' and simplification...
one principle is that we typically don't simplify expressions at creation time, only at transformation time (subject to some exceptions).
I now make this more explicit, making 'simplify' an option to implies (which we don't activate anywhere at the moment). So for the user we wont delete expressions and variables unexpectedly, and for us, if we want it to activate we can.