Open
Conversation
hbierlee
changed the title
round i/o intround i/o int for Gurobi
Contributor
Author
|
Maybe @ThomSerg can have a look since you ran into similar issues recently :) we can also think about follow-up tests / trying out IntegralityFocus |
Contributor
Author
|
Just a note, the "test demonstrating issue" is passing CI because gurobi is not run in CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #858
We should at least use
roundto read integers, because now whenever Gurobi decides to slightly assign an integer variables to a value below rather than above the integer (e.g 0.99999 v. 1.000001), we'll floor/truncate to the (likely) wrong assignment. However, to be even safer, we'll have to look into IntegralityFocus.