Skip to content

Re-enable BVA for Pindakaas/cadical #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hbierlee wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −10
Draft

Re-enable BVA for Pindakaas/cadical #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21408ad
Re-enable BVA
hbierlee Mar 17, 2026
6fb05e3
Try non-parallel
hbierlee Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/python-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,7 @@ jobs:
with:
python-version: '3.10'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
pip install ".[test, z3, exact, pysat, pysdd, choco, minizinc, pindakaas, pumpkin]"
pip install pypblib # dependency of pysat for PB constraints
pip install pytest-xdist
sudo snap install minizinc --classic

run: "python -m pip install --upgrade pip\nif [ -f requirements.txt ]; then pip install -r requirements.txt; fi\npip install \".[test, z3, exact, pysat, pysdd, choco, minizinc, pindakaas, pumpkin]\"\npip install pypblib # dependency of pysat for PB constraints\npip install pytest-xdist\nsudo snap install minizinc --classic \n"
- name: Test with pytest
run: |
python -m pytest -n auto tests/ --solver all -ref
python -m pytest tests/ --solver pindakaas -ref -k partial_div_mod
1 change: 0 additions & 1 deletion cpmpy/solvers/pindakaas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ def __init__(self, cpm_model=None, subsolver=None):
self.encoding = "auto"
self.pdk_solver = pdk.solver.CaDiCaL()
# TODO workaround for upstream issue https://github.com/pindakaashq/pindakaas/issues/189
self.pdk_solver._set_option("factor", 0)
self.unsatisfiable = False # `pindakaas` might determine unsat before solving
self.core = None # latest UNSAT core
super().__init__(name=name, cpm_model=cpm_model)
Expand Down
Loading