Deletion of solver objects and use of model in test_cons#859
Draft
Deletion of solver objects and use of model in test_cons#859
Conversation
This reverts commit 085e453.
hbierlee
changed the title
Collaborator
|
as also reported by Ignace in #808, there is still a big open issue with pysat. More specifically with pypblib in pysat/pb.py, where it seems like pysat is not (doing or able to) free pypblib's memory... |
Collaborator
|
Reported: pysathq/pysat#219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First added by @tias for #850, it has three changes:
modelin test_constraints, which seems good to memodel.solve*, also seems good, but doesn't this happen automatically sincesgoes out of scope?__del__methods for three solvers; I also think that at least for PySAT, it does have its own__del__methods, so these should also be called automatically?