security: document hardcoded OAuth credentials and password handling#89
Open
AidanDalyAus wants to merge 1 commit intoCJNE:mainfrom
Open
security: document hardcoded OAuth credentials and password handling#89AidanDalyAus wants to merge 1 commit intoCJNE:mainfrom
AidanDalyAus wants to merge 1 commit intoCJNE:mainfrom
Conversation
CLIENT_ID and X_CLIENT_ID hardcoded in const.py. Password stored in Credentials NamedTuple for connection lifetime. Co-Authored-By: Aidan Daly <me@aidandaly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents hardcoded CLIENT_ID/X_CLIENT_ID and plaintext password persistence in Credentials NamedTuple. Adds SECURITY.md with recommendations.