Minor modifications to ietf-system-capabilities state RFC 9196#1790
Merged
michalvasko merged 2 commits intoCESNET:develfrom Mar 11, 2026
Merged
Minor modifications to ietf-system-capabilities state RFC 9196#1790michalvasko merged 2 commits intoCESNET:develfrom
michalvasko merged 2 commits intoCESNET:develfrom
Conversation
As per-node-capabilities is a keyless list. Create the node-selector with lyd_new_term. Fixes: 473e0ff ("main UPDATE implement capabilities modules (CESNET#1715)") Link: https://datatracker.ietf.org/doc/html/rfc9196#section-4.2 Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
Member
|
I do not generally have a problem with the changes but since the subscriptions are handled by sysrepo, periodic subscriptions will always be supported for all the data. As for on-change, those may not be supported for some Regarding the failing tests, I was just about to fix it but okay, since you did. |
Contributor
Author
|
Ok so I will remove the patch in the middle. |
Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
michalvasko
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I propose those two patches to modify the content of the ietf-system-capabilities state.
For the first patch:
"/" xpath is missing from the state.
As per-node-capabilities is a keyless list. Create the node-selector with lyd_new_term.
For the 2nd patch:
I removed the config-changes and state-changes, so another application can merge
custom xpaths with custom support for on-change and periodic notifications.
Thank you.
Best regards,
Jeremie