refactor(health): replace deprecated datetime.utcnow() with timezone-aware datetime#1056
Open
MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
Open
refactor(health): replace deprecated datetime.utcnow() with timezone-aware datetime#1056MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
MrButtCode
requested review from
canihavesomecoffee and
thealphadollar
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves multiple
DeprecationWarningsinmod_health/controllers.pycaused by the use ofdatetime.utcnow().Python 3.12 formally deprecated
datetime.utcnow()in favor of timezone-aware objects. To harden the health module for newer Python runtimes while preserving the exact JSON API contract for existing consumers, I migrated the calls todatetime.now(timezone.utc).To prevent Python from appending the explicit
+00:00timezone offset (which would break the existing.isoformat() + 'Z'manual concatenation), the timezone info is stripped prior to formatting using.replace(tzinfo=None). This ensures flawless backward compatibility with the current frontend/API consumers while satisfying Python 3.12+ requirements.