fix(auth): replace deprecated passlib encrypt method with hash#1055
Open
MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
Open
fix(auth): replace deprecated passlib encrypt method with hash#1055MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
MrButtCode wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
…thon 3.13 compatibility
MrButtCode
requested review from
canihavesomecoffee and
thealphadollar
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a critical
DeprecationWarninginmod_auth/models.pygenerated bypasslibby migrating from the legacy.encrypt()method to the modern.hash()method.The test suite was throwing:
DeprecationWarning: the method passlib.context.CryptContext.encrypt() is deprecated as of Passlib 1.7...While currently just a warning in Python 3.12, the underlying
cryptmodule that older passlib methods rely on has been completely removed in Python 3.13 (PEP 594). By updating this to the modern.hash()API now, this PR hardens the authentication module for forward-compatibility, ensuring the platform doesn't hit a hard crash during future Python runtime upgrades.