Skip to content

Revert SQLAlchemy identity check and add error display #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canihavesomecoffee merged 2 commits into from
Mar 7, 2026
Merged

Revert SQLAlchemy identity check and add error display #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e95f21
Reapply "fix: use SQLAlchemy .is_(False) instead of Python identity c…
canihavesomecoffee Mar 7, 2026
d834297
fix: Add error display for edge case
canihavesomecoffee Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mod_test/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def get_test_results(test) -> List[Dict[str, Any]]:
# We need to check if the regression test had any file that shouldn't have been ignored.
outputs = RegressionTestOutput.query.filter(and_(
RegressionTestOutput.regression_id == category_test['test'].id,
RegressionTestOutput.ignore is False
RegressionTestOutput.ignore.is_(False)
)).all()
got = None
if len(outputs) > 0:
Expand Down
2 changes: 2 additions & 0 deletions templates/test/by_id.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ <h4 class="category-header {{ 'fail' if result.error else 'pass' }}" data-catego
{%- endif %}
{% elif file.got is none or no_error.found or test.result.exit_code != 0 -%}
Pass
{% elif file.got == "error" %}
No output generated but there should be
{% else %}
<a href="#" class="diff_link" data-test="{{ file.test_id }}" data-regression="{{ file.regression_test_id }}" data-output="{{ file.regression_test_output_id }}">Fail</a>
{%- endif %}
Expand Down