fix: restore agent API-key auth for task comments/execution#73
Merged
Conversation
- align tasks optionalAuth API-key lookup with auth middleware hash logic - use Node crypto SHA-256 against key_hash instead of SQL digest expression - allow agent-auth comments by using nullable author_id and preserving agent metadata in task log events Co-authored-by: Holden Omans <holden.omans@gmail.com>
kalinon
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasksroute optional auth for machine-agent API keys (mba_*)authmiddleware (NodecryptoSHA-256 ->key_hashlookup)author_id) while preserving agent metadata in task logsRoot cause
tasks.jsused a different API-key lookup path (encode(digest(...))) thanauth.js(crypto.createHash('sha256')). In practice this leftreq.userunset for strict endpoints (/tasks/:id/comments,/tasks/:id/execution), causing401 Authorization required.Validation
npm run -w ./api lint -- src/routes/tasks.jsnpm run -w ./api test:run -- src/routes/__tests__/tasks.edge-cases.test.js[ACK]and[DONE]commentsAGENT_PROGRESS,AGENT_DONE)last_agent_id,last_session_key,last_reported_at)