fix: fallback session-id copy when Clipboard API is unavailable#70
Merged
fix: fallback session-id copy when Clipboard API is unavailable#70
Conversation
- guard navigator.clipboard access in SessionDetailPanel copy chip
- fallback to document.execCommand('copy') for non-secure contexts
- avoid uncaught exceptions when clipboard API is undefined
Co-authored-by: Holden Omans <holden.omans@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Agent Monitor session copy failures in production contexts where
navigator.clipboardis unavailable.Problem
In some deployment contexts (non-secure origins / constrained webviews),
navigator.clipboardis undefined, causing:TypeError: can't access property "writeText", navigator.clipboard is undefinedFix
navigator.clipboard.writeTextdocument.execCommand('copy')File
web/src/components/SessionDetailPanel.jsxValidation
npm run build(web) passes