Allow deserialize_any to call visit_none on empty cells#250
Open
msrd0 wants to merge 1 commit intoBurntSushi:masterfrom
Open
Allow deserialize_any to call visit_none on empty cells#250msrd0 wants to merge 1 commit intoBurntSushi:masterfrom
msrd0 wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to deserialize
Option<chrono::NaiveTime>from inside a custom deserialize implementation that callsdeserialize_mapand thennext_key/next_valuewith all type info available. Nevertheless, it ends up callingdeserialize_anyinstead ofdeserialize_option, and then fails to parse on empty cells instead of returningNoneas I'd expect. This PR allowsdeserialize_anyto treat empty fields asNone.