Issue 69 - Saving Promise breaks "What It Means for Canadians"#96
Merged
xrendan merged 2 commits intoBuildCanada:mainfrom Sep 24, 2025
Merged
Issue 69 - Saving Promise breaks "What It Means for Canadians"#96xrendan merged 2 commits intoBuildCanada:mainfrom
xrendan merged 2 commits intoBuildCanada:mainfrom
Conversation
xrendan
approved these changes
Sep 24, 2025
Member
xrendan
left a comment
xrendan
left a comment
There was a problem hiding this comment.
This is great, ideally this wouldn't have been an array in the first place, but this will make things a lot better going forward!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comment on the issue for the full details: #69 (comment)
I adjusted the parsing algo to handle empty strings and setting avo error. The avo field has validation to show the error on the save in the admin.
Feel free to adjust or correct any parts of this fix.