Enforce admin authentication in all environments#120
Merged
Conversation
Previously, admin routes (Avo, GoodJob) were unprotected in development and Avo's authenticate_with block was commented out. This enforces Warden-based auth and admin-only route guards unconditionally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/admin/good_job,/admin) were previously unprotected in development. Now wrapped inauthenticate :user, lambda { |u| u.admin? }unconditionally.authenticate_withblock was commented out; now enforceswarden.authenticate! scope: :userso Avo itself requires authentication.Why
Admin tooling (GoodJob dashboard, Avo) was accessible without any auth in development, which is inconsistent with production behavior and a security gap if dev environments are ever exposed.
Test plan
/adminand/admin/good_jobwhile logged out — expect redirect to login🤖 Generated with Claude Code