feat: add annex to env#345
Open
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
Conversation
Contributor
|
LGTM I copied most of #331 for this. Gonna take a look at fixing CI first |
stringhandler
force-pushed
the
feat/add-annex
branch
from
7ce98ca to
61440dc
Compare
Collaborator
|
CI is passing -- can this be undrafted? |
Contributor
Author
|
done |
Collaborator
|
In 7ce98ca: Please separate out the typo fixes and the serde stuff (is this necessary at all?) into separate commits. |
apoelstra
reviewed
Mar 13, 2026
| annex: inp_data | ||
| .annex | ||
| .as_ref() | ||
| .map(|annex| c_elements::CRawBuffer::new(annex)) |
Collaborator
There was a problem hiding this comment.
In 7ce98ca:
This creates a dangling raw pointer and is unsound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the annex to the transaction environment so that it is included in hashes created by jets.
This is almost entirely coded by @delta1 but is required to add functionality to
hal-simplicityand can be seen/tested here https://github.com/stringhandler/hal-simplicity/tree/feat/add-annex.