[SC-6159] Add kycHash to StakeOptions for XDC masternode staking#8298
Draft
Doddanna17 wants to merge 1 commit intomasterfrom
Draft
[SC-6159] Add kycHash to StakeOptions for XDC masternode staking#8298Doddanna17 wants to merge 1 commit intomasterfrom
Doddanna17 wants to merge 1 commit intomasterfrom
Conversation
Add optional kycHash field to StakeOptions interface to support XDC masternode staking. The field carries the IPFS CID of the KYC document uploaded via the staking-service KYC upload endpoint before staking. stakingWallet.stake() spreads all StakeOptions fields into the POST body automatically, so no further changes are needed. Ticket: SC-6159
Doddanna17
force-pushed
the
SC-6159-xdc-kyc-hash-stake-options
branch
from
9303cc5 to
a99eb82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
kycHash?: stringtoStakeOptionsiniStakingWallet.tsto support XDC masternode staking.File changed:
modules/sdk-core/src/bitgo/staking/iStakingWallet.tsContext
XDC masternode staking requires a 2-step flow:
POST /kyc/upload→{ hash: "QmTzQ1..." }{ validator, kycHash }→ creates AUTHORIZE + DELEGATE txsThe
kycHashis obtained from the staking-service KYC upload endpoint (PR: BitGo/staking-service#6582) and must be forwarded in the stake request body. SincestakingWallet.stake()spreads allStakeOptionsfields into the POST body, only this interface change is needed.validator?: stringalready exists inStakeOptions— no further changes required.Related
Ticket: SC-6159