Conversation
* Add interface to ManiSkill simulator * Add optional maniskill dependencies * Format with black
Fix two ManiSkill-related issues: - Sphinx docs were failing when ManiSkill wasn’t installed. Add a shared buildingScenicDocumentation() helper, mock ManiSkill deps in autodoc_mock_imports, and only register ScenicEnv outside doc builds. - pip install "scenic[maniskill]" previously hit pip's "resolution-too-deep" error. Tighten the extra to require gymnasium >= 1.0.0 so the resolver converges with current releases.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 89.65% 89.69% +0.04%
==========================================
Files 48 48
Lines 13194 13198 +4
==========================================
+ Hits 11829 11838 +9
+ Misses 1365 1360 -5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic support for the ManiSkill simulator in Scenic and provides two examples to demonstrate this integration.
This PR is based on work originally developed by @Maciej4 in #400.
Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes