Skip to content

Fix errors & warnings for compose blocks#443

Merged
lola831 merged 2 commits intomainfrom
fix_stuck_scenario_warning
Mar 17, 2026
Merged

Fix errors & warnings for compose blocks#443
lola831 merged 2 commits intomainfrom
fix_stuck_scenario_warning

Conversation

@dfremont
Copy link
Collaborator

@dfremont dfremont commented Mar 16, 2026

Description

While debugging I noticed that the warning for modular scenarios whose compose block is stuck doesn't work, since I forgot a couple of imports. It turns out we have a test for stuck behaviors but not for stuck scenarios. So I've fixed the bug and added a test.

The error message for compose blocks that don't invoke any subscenarios (or use wait) also didn't work, so I've fixed that and added a test.

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

@dfremont dfremont requested a review from lola831 March 16, 2026 20:20
@dfremont dfremont changed the title Fix warning for stuck modular scenarios Fix errors & warnings for compose blocks Mar 16, 2026
Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested this locally, and the new test passes. The CI failure appears to be from an unrelated flaky test, not from the changes in this PR, so I'm going ahead and merging.

@lola831 lola831 merged commit 8abd7b2 into main Mar 17, 2026
5 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants