Fix errors & warnings for compose blocks#443
Merged
Conversation
lola831
approved these changes
Mar 17, 2026
Collaborator
lola831
left a comment
There was a problem hiding this comment.
Looks good. I tested this locally, and the new test passes. The CI failure appears to be from an unrelated flaky test, not from the changes in this PR, so I'm going ahead and merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging I noticed that the warning for modular scenarios whose
composeblock is stuck doesn't work, since I forgot a couple of imports. It turns out we have a test for stuck behaviors but not for stuck scenarios. So I've fixed the bug and added a test.The error message for
composeblocks that don't invoke any subscenarios (or usewait) also didn't work, so I've fixed that and added a test.Checklist
pytestand/or other means