Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety#403
Merged
tastybento merged 2 commits intodevelopfrom Mar 2, 2026
Merged
Conversation
…alidate cache on update Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect order in top ten standings
Fix top ten ordering: use ConcurrentHashMap for thread-safe access
Mar 2, 2026
Copilot
AI
changed the title
Fix top ten ordering: use ConcurrentHashMap for thread-safe access
Fix top ten ordering: replace LinkedHashMap with ConcurrentHashMap for thread safety
Mar 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Top ten leaderboard displays islands in wrong order — e.g., level 65 in 1st place, level 1065 in 6th. The sorting logic in
calculateTopTen()is correct, but the underlyingTopTenData.topTenmap is aLinkedHashMapconcurrently mutated from async threads (loadTopTens,setIslandResults) and read/modified from the main thread (getTopTen,createAndCleanRankings). This corruptsLinkedHashMap's internal doubly-linked list, producing incorrect iteration results that the downstream sort operates on. A server restart does not fix this — the same race re-occurs during asyncloadTopTens()repopulation.Changes
TopTenData:LinkedHashMap→ConcurrentHashMap. Insertion order is irrelevant here sincecalculateTopTen()always sorts into a freshLinkedHashMap.LevelsManager.addToTopTen(): Invalidate the 1-second sorted cache viacache.remove(world)on level updates, matching the existing pattern inremoveEntry().LevelsManagerTest: AddedtestGetTopTenSortOrder()covering the reported scenario (mixed insertion order, verifies descending output).Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.