Skip to content

Fix Firmware Update Text#533

Merged
AJediIAm merged 2 commits intoBenPru:mainfrom
kiall:fix-firmware-text
Mar 23, 2026
Merged

Fix Firmware Update Text#533
AJediIAm merged 2 commits intoBenPru:mainfrom
kiall:fix-firmware-text

Conversation

@kiall
Copy link
Copy Markdown
Contributor

@kiall kiall commented Mar 21, 2026

In ace7e86#diff-b3f725dd5516950cb95e4502581968f549ff989082c88e390e8aed2b29c79dc5L141-R144, the links were half removed, spaces were missing, causing broken auto-links etc

This restores the formatting to be readable & fixes the links.

Firmware Update Entity with this PR:

image

Firmware Update Entity prior to this PR:

image

kiall added 2 commits March 21, 2026 07:41
In BenPru@ace7e86#diff-b3f725dd5516950cb95e4502581968f549ff989082c88e390e8aed2b29c79dc5L141-R144, the links
were half removed, spaces were missing, causing broken auto-links etc

This restores the formatting to be readable & fixes the links.
@kiall
Copy link
Copy Markdown
Contributor Author

kiall commented Mar 23, 2026

It looks like CI linting / auto-commit is failing due to the checkout steps with.ref/with.repository values.

The git-auto-commit-action docs suggest both are needed for using that action with forks, however it also mentions this could be a security issue to allow:

https://github.com/stefanzweifel/git-auto-commit-action?tab=readme-ov-file#use-in-forks-from-public-repositories

@AJediIAm
Copy link
Copy Markdown
Collaborator

I was just looking in to it.
I'll disabled auto commit for forks.
It's not blocking for this change

@AJediIAm AJediIAm merged commit a701aaa into BenPru:main Mar 23, 2026
6 of 9 checks passed
@kiall kiall deleted the fix-firmware-text branch March 23, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants