Add initial AAC module skeleton and register sources in Qt client build#3079
Closed
trancer1994 wants to merge 10 commits intoBearWare:masterfrom
Closed
Add initial AAC module skeleton and register sources in Qt client build#3079trancer1994 wants to merge 10 commits intoBearWare:masterfrom
trancer1994 wants to merge 10 commits intoBearWare:masterfrom
Conversation
Author
|
More commits will be coming, but I've added the first file that's needed here. I'll work on the rest of it in the next few days. |
trancer1994
changed the title
Contributor
|
Why did you create a src folder? It seems like you should just add the files, or move the aac folder out one level. |
Author
|
I'm honestly not sure why i created that folder. I think it was because at the time I didn't want to confuse it with the UI we already had, but then again, once everything is submitted, it'll be a whole redesign of everything, and for things like that you don't want confusion. If you want though, I'll move the aac folder out one level to make it easier to review.
…________________________________
From: Sihu Hwang ***@***.***>
Sent: 06 January 2026 12:36
To: BearWare/TeamTalk5 ***@***.***>
Cc: trancer1994 ***@***.***>; Author ***@***.***>
Subject: Re: [BearWare/TeamTalk5] Add initial AAC module skeleton and register sources in Qt client build (PR #3079)
[https://avatars.githubusercontent.com/u/129564966?s=20&v=4]hwangsihu left a comment (BearWare/TeamTalk5#3079)<#3079 (comment)>
Why did you create a src folder? It seems like you should just add the files, or move the aac folder out one level.
—
Reply to this email directly, view it on GitHub<#3079 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMV3XJRMBL2L53T7BJFTS5T4FOT6XAVCNFSM6AAAAACQVNU7CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJUGU2DQNZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
|
Actually, scrap what I just wrote. There's a very good reason behind the folder's creation.
I introduced the src/ folder in this initial skeleton because the AAC‑native UI module is architecturally separate from the existing Qt UI code. The goal was to keep the early scaffolding isolated while the state machine, input model, and AAC‑specific components take shape, so the initial review stays focused and the module remains easy to move or reorganize as feedback comes in.
That said, I’m not attached to the folder name or level. If the project’s convention is to place new modules directly under the client directory, I can move the aac/ folder up one level in the next commit. The intent was clarity during development, not to introduce a new top‑level structure unless it aligns with the maintainers’ preferences.
Let me know which placement fits best with the existing layout and I’ll adjust accordingly.
…________________________________
From: Sihu Hwang ***@***.***>
Sent: 06 January 2026 12:36
To: BearWare/TeamTalk5 ***@***.***>
Cc: trancer1994 ***@***.***>; Author ***@***.***>
Subject: Re: [BearWare/TeamTalk5] Add initial AAC module skeleton and register sources in Qt client build (PR #3079)
[https://avatars.githubusercontent.com/u/129564966?s=20&v=4]hwangsihu left a comment (BearWare/TeamTalk5#3079)<#3079 (comment)>
Why did you create a src folder? It seems like you should just add the files, or move the aac folder out one level.
—
Reply to this email directly, view it on GitHub<#3079 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMV3XJRMBL2L53T7BJFTS5T4FOT6XAVCNFSM6AAAAACQVNU7CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJUGU2DQNZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
Well, then it's better to deal with that issue later. It's not important anyway. |
Author
|
What are you refering to? The folder src/aac, or the technical reason for that folder's existance?
…________________________________
From: Sihu Hwang ***@***.***>
Sent: 06 January 2026 23:05
To: BearWare/TeamTalk5 ***@***.***>
Cc: trancer1994 ***@***.***>; Author ***@***.***>
Subject: Re: [BearWare/TeamTalk5] Add initial AAC module skeleton and register sources in Qt client build (PR #3079)
[https://avatars.githubusercontent.com/u/129564966?s=20&v=4]hwangsihu left a comment (BearWare/TeamTalk5#3079)<#3079 (comment)>
Well, then it's better to deal with that issue later. It's not important anyway.
—
Reply to this email directly, view it on GitHub<#3079 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMV3XJRZCFTVBAJL27YLT5L4FQ5SHAVCNFSM6AAAAACQVNU7CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJWGY3TEOBZGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
It was about changing src/aac to aac. We can discuss it again later when development has progressed, but it's okay to change it now. |
Author
|
Are you sure it's not going to confuse Bjorn though?
…________________________________
From: Sihu Hwang ***@***.***>
Sent: 07 January 2026 14:07
To: BearWare/TeamTalk5 ***@***.***>
Cc: trancer1994 ***@***.***>; Author ***@***.***>
Subject: Re: [BearWare/TeamTalk5] Add initial AAC module skeleton and register sources in Qt client build (PR #3079)
[https://avatars.githubusercontent.com/u/129564966?s=20&v=4]hwangsihu left a comment (BearWare/TeamTalk5#3079)<#3079 (comment)>
It was about changing src/aac to aac. We can discuss it again later when development has progressed, but it's okay to change it now.
—
Reply to this email directly, view it on GitHub<#3079 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMV3XJU2T2OG3SJWLCRNGAL4FUHINAVCNFSM6AAAAACQVNU7CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJZGA2TCNZXG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
Superceeded by #3111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the initial skeleton for the AAC UI module.
It adds the following new source files under
src/aac/:These files define the basic structure for the upcoming AAC‑native interaction model, but contain no functional logic yet.
The CMakeLists.txt file has been updated to include these new sources so they are compiled as part of the Qt client. No existing UI, behavior, or application flow is modified.
This PR is intentionally minimal and non‑intrusive.
Future PRs will build on this foundation by implementing:
This PR is safe to merge and does not affect current functionality.