Ensure determinism of calculation when using full-batch#4
Open
mohdibntarek wants to merge 2 commits intoBayesianRL:mainfrom
Open
Ensure determinism of calculation when using full-batch#4mohdibntarek wants to merge 2 commits intoBayesianRL:mainfrom
mohdibntarek wants to merge 2 commits intoBayesianRL:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this nice Julia package. I was playing around with it and noticed that the metric and velocity calculations are not deterministic even when using full-batch, due to the order of floating point operations changing in each call. This PR fixes that.