fix(face-tracking): make host authoritative for activity state and neutralize startup sync#582
Open
Toys0125 wants to merge 6 commits intoBasisVR:developerfrom
Open
fix(face-tracking): make host authoritative for activity state and neutralize startup sync#582Toys0125 wants to merge 6 commits intoBasisVR:developerfrom
Toys0125 wants to merge 6 commits intoBasisVR:developerfrom
Conversation
…utralize startup sync * Added an internal `FaceTrackingActivityRelay` channel (`HVR/Internal/FaceTrackingActive`) with a host-only inactivity timeout (0.5s). Remotes now follow host activity and do not run their own timeout logic. * Wired OSC input to activity updates so any incoming face packet marks tracking active. * Fixed remote eye application in `EyeTrackingBoneActuation` (!IsLocal && Receiver != null) and ensured remote override flags are cleared when tracking is inactive/disabled. * Gated eye and blendshape actuation behind propagated tracking activity: Active: HVR drives local/remote face data. Inactive: reset HVR-driven values to neutral and return control to Basis default behavior. * Stopped applying startup/default blendshape overrides when tracking is inactive; defaults are only pushed while tracking is active. * Changed mutualized feature initialization to neutral normalized values based on interpolation ranges (AbsoluteToRange(0) when 0 is in range), preventing signed channels from booting at low-end values (e.g. unintended TongueLeft). * Updated networking init flow to seed neutral values before initial replay, and fixed wearer/range bookkeeping issues in `HVRAvatarComms`.
…utralize startup sync * Added an internal `FaceTrackingActivityRelay` channel (`HVR/Internal/FaceTrackingActive`) with a host-only inactivity timeout (0.5s). Remotes now follow host activity and do not run their own timeout logic. * Wired OSC input to activity updates so any incoming face packet marks tracking active. * Fixed remote eye application in `EyeTrackingBoneActuation` (!IsLocal && Receiver != null) and ensured remote override flags are cleared when tracking is inactive/disabled. * Gated eye and blendshape actuation behind propagated tracking activity: Active: HVR drives local/remote face data. Inactive: reset HVR-driven values to neutral and return control to Basis default behavior. * Stopped applying startup/default blendshape overrides when tracking is inactive; defaults are only pushed while tracking is active. * Changed mutualized feature initialization to neutral normalized values based on interpolation ranges (AbsoluteToRange(0) when 0 is in range), preventing signed channels from booting at low-end values (e.g. unintended TongueLeft). * Updated networking init flow to seed neutral values before initial replay, and fixed wearer/range bookkeeping issues in `HVRAvatarComms`.
…into Fix-Face-Tracking
Collaborator
|
break out the other changes to just what is needed and run that by hai please |
Contributor
Author
Okay done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FaceTrackingActivityRelaychannel (HVR/Internal/FaceTrackingActive) with a host-only inactivity timeout (0.5s). Remotes now follow host activity and do not run their own timeout logic.EyeTrackingBoneActuation(!IsLocal && Receiver != null) and ensured remote override flags are cleared when tracking is inactive/disabled.Active: HVR drives local/remote face data.
Inactive: reset HVR-driven values to neutral and return control to Basis default behavior.
HVRAvatarComms.