Expand the functionality of the linked list#112
Draft
Smidqe wants to merge 9 commits intoBTDev:masterfrom
Draft
Conversation
|
|
||
| return null; | ||
| } | ||
| LinkedList.Circular.prototype.multiple = function(indexes) { |
Contributor
There was a problem hiding this comment.
I would suggest making sure that this method has a verb in the name (unless this name comes from a standard somewhere?). It's fairly clear what it does at the callsites, but it took a second to figure out what it did when I first saw this line. Something like getMultipleByIndex or something.
super-nitpicky optimization suggestions:
- construct the result array in the loop to remove the last line:
const result = [];
for (...) {
if (stuff) {
result.push(...);
}
}
return result;- use a
Setinstead ofMapto save a few array allocations - calculate the max index at the same time as populating the
Set
| } | ||
| } | ||
|
|
||
| LinkedList.Circular.prototype.indexOf = function(cb) { |
Contributor
There was a problem hiding this comment.
nit: I'm guessing this should be findIndex if you're wanting to keep aligned with the same naming as the array functions
Member
|
While you're at it, maybe the linked list should be turned into a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment all iterations on playlist have to be done manually every time something is needed, creating unnecessary code duplication.
This pull request introduces methods on the linked list to unify these operations (ideally playlist would be an array).