Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
SNT-387 TopBar styling
Related JIRA tickets
SNT-387
Changes
Top bar accepts a SX prop.
Did this as there is no default theme in iaso yet and I didn't wanted to break any other plugins.
Otherwise we should have use theme overrides.
How to test
Check related SNT PR to test this : BLSQ/snt-malaria#239
But in IASO it should break anything.
Print screen / video
N/A
Notes
Things that the reviewers should know:
Doc
Tell us where the doc can be found (docs folder, wiki, in the code...).