feat: Google Drive 권한 연결 URL 조회 API 추가#489
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (2)src/main/java/**/*.java⚙️ CodeRabbit configuration file
Files:
**/*⚙️ CodeRabbit configuration file
Files:
📝 Walkthrough개요Google Drive OAuth 인증 URL을 조회하는 새로운 엔드포인트 변경 사항
시 (Poem)
예상 코드 리뷰 시간🎯 2 (Simple) | ⏱️ ~12분 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Google Drive 권한 재연결 플로우에서 프론트엔드가 리다이렉트 없이도 바로 사용할 수 있도록, 로그인 사용자 기준 Google Drive OAuth authorize URL을 JSON으로 반환하는 API를 추가한 PR입니다.
Changes:
GET /auth/oauth/google/drive/authorize-url엔드포인트 추가 및authorizationUrlJSON 응답 제공- authorize URL 응답용 DTO(
GoogleDriveAuthorizationUrlResponse) 추가 - 신규 엔드포인트 동작을 검증하는 통합 테스트(
GoogleDriveOAuthControllerTest) 추가
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/gg/agit/konect/infrastructure/oauth/GoogleDriveOAuthController.java | authorize URL을 JSON으로 반환하는 신규 GET 엔드포인트 및 Swagger Operation/Tag 메타데이터 추가 |
| src/main/java/gg/agit/konect/infrastructure/oauth/dto/GoogleDriveAuthorizationUrlResponse.java | 프론트에서 그대로 사용할 authorizationUrl 응답 DTO(record) 추가 |
| src/test/java/gg/agit/konect/integration/infrastructure/oauth/GoogleDriveOAuthControllerTest.java | 로그인 사용자 기준 authorize URL JSON 응답을 반환하는지 통합 테스트 추가 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
GoogleDriveOAuthController에GET /auth/oauth/google/drive/authorize-url엔드포인트를 추가해 로그인 사용자의 Google Drive authorize URL을 JSON으로 반환하도록 구현했습니다.GoogleDriveAuthorizationUrlResponseDTO를 추가해 프론트가authorizationUrl필드를 그대로 사용해 브라우저 이동할 수 있게 했습니다.GoogleDriveOAuthControllerTest를 추가해 새 엔드포인트가 로그인 사용자 기준 authorize URL을 정상 반환하는지 검증했습니다.💬 참고 사항
GET /auth/oauth/google/drive/authorize의 302 redirect 방식은 그대로 유지했습니다.authorizationUrl로window.location이동만 해주면 됩니다../gradlew.bat test --tests "gg.agit.konect.integration.infrastructure.oauth.GoogleDriveOAuthControllerTest"로 확인했습니다.✅ Checklist (완료 조건)