Open
Conversation
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves clarity and reduces noise in autoentities-related logging across the runtime and CLI, aligning terminology/casing and making some parameter logs Debug-level.
Changes:
- Standardizes log/error message wording to consistently use
autoentitiesand to quote definition names (e.g.,'name'). - Lowers autoentities query parameter logging from Information to Debug (MSSQL metadata provider).
- Updates a few CLI outputs related to autoentities simulation for consistent casing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Core/Services/MetadataProviders/SqlMetadataProvider.cs | Standardizes “Autoentities” → “autoentities” in a NotSupportedException message. |
| src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs | Improves autoentities-related error/log strings, switches query-parameter logs to Debug, and changes QueryAutoentitiesAsync signature to include the definition name. |
| src/Config/ObjectModel/RuntimeConfig.cs | Updates exception message for invalid autoentities definition lookup. |
| src/Cli/ConfigGenerator.cs | Standardizes autoentities simulation CLI wording/casing. |
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
…entities-fix-logs' into dev/rubencerna/autoentities-fix-logs
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
Mar 20, 2026
| { | ||
| throw new DataApiBuilderException( | ||
| message: $"Cannot create new entity from autoentity pattern due to an internal error.", | ||
| message: $"Cannot create new entity from autoentities definition '{autoentityName}' due to an internal error.", |
Collaborator
There was a problem hiding this comment.
As per the bug #3264 , the message should be:
Cannot create new entity from autoentities member 'autoentityName' due to an internal error
whereas the other bug says it should be definition.
Clarify that there is a discrepancy in expectation. I do think definition is the right term to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
debug#3263dab validateis incorrect. #3265Currently some of the logs for autoentities are not completely clear or they are too noisy. Which is why the messages need to be changed.
What is this change?
This changes the log messages so they are more clear by adding
' 'to the definition names from the autoentities, and stating that they are definition names beforehand. We also change the name fromAutoentitiestoautoentitiesin the logs so that they are all consistent.Lastly we also change some of the logs from
InformationtoDebug.How was this tested?
Tested locally since all the changes are related to the messages written in the logs.