Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xuming-ms
requested review from
DanielMicrosoft,
ReaNAiveD,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
|
@xuming-ms please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
Contributor
|
@xuming-ms please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure CLI’s pinned and declared dependency on azure-core to pick up upstream behavior that stops reading the overly-generic AZURE_CLOUD environment variable (now using AZURE_SDK_CLOUD_CONF), reducing the chance of cloud-name parsing conflicts in the SDK.
Changes:
- Bump
azure-corefrom1.38.0to1.39.0in the platform-specific pinned requirements files (Windows/Linux/macOS). - Bump
azure-cli-core’sinstall_requiresconstraint toazure-core~=1.39.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/requirements.py3.windows.txt | Updates pinned azure-core version to 1.39.0 for Windows builds. |
| src/azure-cli/requirements.py3.Linux.txt | Updates pinned azure-core version to 1.39.0 for Linux builds. |
| src/azure-cli/requirements.py3.Darwin.txt | Updates pinned azure-core version to 1.39.0 for macOS builds. |
| src/azure-cli-core/setup.py | Updates azure-cli-core dependency constraint to allow azure-core 1.39.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
N/A - dependency update
Description
Bump azure-core from 1.38.0 to 1.39.0.
This update picks up the rename of the AZURE_CLOUD environment variable to AZURE_SDK_CLOUD_CONF (Azure/azure-sdk-for-python#45763). The old AZURE_CLOUD variable was too general that it conflicted with other software, causing ValueError: Cannot convert AzureCloud to Azure Cloud when its value is not understood by SDK. With this bump, azure-core stops reading AZURE_CLOUD and reads AZURE_SDK_CLOUD_CONF instead, resolving the conflict.
Testing Guide
Ran azure-cli-core unit tests locally — no new failures introduced by this change.
History Notes
[Core] Bump azure-core to 1.39.0 to resolve ValueError caused by AZURE_CLOUD environment variable conflict