Refactor: use `az account show` for tenant ID and subscription ID; move kubeconfig/k8s helpers to shared packages by Copilot · Pull Request #55 · Azure/aks-flex

Copilot · 2026-03-17T00:58:29Z

Analyze comments and understand codebase
Update defaultSubscriptionID() to use az account show --query 'id' -o tsv
Fix tab indentation in APIServerFromKubeconfigFile
Add contextName string parameter to APIServerFromKubeconfigFile (empty = use current-context)
Update cilium.go to pass cfg.ClusterName+"-admin" context name matching the --context flag
Extract cfg.ClusterName+"-admin" as clusterContext variable; reuse in APIServerFromKubeconfigFile, --context, and log.Printf
All tests pass

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ions to shared packages Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho

@copilot

bcho · 2026-03-17T01:18:43Z

plugin/pkg/util/config/config.go

@copilot do a similar update to extract sub id from az cli output for this function

Done in 7fee6b5. defaultSubscriptionID() now uses az account show --query 'id' -o tsv, dropping the clouds.config / ini dependency.

bcho · 2026-03-17T01:19:15Z

plugin/pkg/util/k8s/k8s.go

+// APIServerFromKubeconfigFile returns the API server hostname and port from
+// the current context of the kubeconfig file at path.
+func APIServerFromKubeconfigFile(path string) (host, port string, err error) {
+kcfg, err := clientcmd.LoadFromFile(path)


@copilot wrong format

Fixed in 7fee6b5. The function body was appended without tabs — restored proper Go indentation.

…onfigFile Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho

@copilot

bcho · 2026-03-17T01:32:01Z

plugin/pkg/util/k8s/k8s.go

+
+// APIServerFromKubeconfigFile returns the API server hostname and port from
+// the current context of the kubeconfig file at path.
+func APIServerFromKubeconfigFile(path string) (host, port string, err error) {


@copilot add support for passing the context name to load

Done in 1f10452. APIServerFromKubeconfigFile now takes a contextName string — when non-empty it uses that context directly; when empty it falls back to the file's current-context.

bcho · 2026-03-17T01:32:29Z

cli/internal/aks/deploy/cilium.go

 	cfg *config.Config,
 ) error {
-	k8sServiceHost, k8sServicePort, err := kubeconfigAPIServer(kubeconfigFile)
+	k8sServiceHost, k8sServicePort, err := k8s.APIServerFromKubeconfigFile(kubeconfigFile)


@copilot pass in the context name to load to match with the --context used in the below

Done in 1f10452. Now passes cfg.ClusterName+"-admin" as the context name, matching the --context flag used by cilium install.

…t in cilium deploy Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho · 2026-03-17T01:39:20Z

cli/internal/aks/deploy/cilium.go

 	cfg *config.Config,
 ) error {
-	k8sServiceHost, k8sServicePort, err := kubeconfigAPIServer(kubeconfigFile)
+	k8sServiceHost, k8sServicePort, err := k8s.APIServerFromKubeconfigFile(kubeconfigFile, cfg.ClusterName+"-admin")


extract cfg.ClusterName + "-admin" as a variable then reuse with the later helm cmd parameters reference @copilot

Done in 217c0c3. Extracted clusterContext := cfg.ClusterName + "-admin" and reused it in APIServerFromKubeconfigFile, the --context flag, and log.Printf.

…ver lookup and cilium install flags Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

* fix node bootstrap script for held kube packages * fix Azure profile-aware AKS Flex bootstrap * Refactor: use `az account show` for tenant ID and subscription ID; move kubeconfig/k8s helpers to shared packages (#55) * Initial plan * Address review feedback: use az CLI for tenant ID, move utility functions to shared packages Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> * Use az CLI for subscription ID; fix indentation in APIServerFromKubeconfigFile Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> * Add contextName parameter to APIServerFromKubeconfigFile; pass context in cilium deploy Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> * Extract clusterContext variable in deployCilium; reuse across API server lookup and cilium install flags Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Run go mod tidy across all submodules (#56) * Initial plan * Run go mod tidy across all submodules (cli, karpenter, plugin) Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> --------- Co-authored-by: Qi Ke <noreply@ked.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: bcho <1975118+bcho@users.noreply.github.com> Co-authored-by: hbc <bahe@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Initial plan

c245107

Copilot AI assigned Copilot and bcho Mar 17, 2026

Copilot AI mentioned this pull request Mar 17, 2026

fix Azure profile-aware AKS Flex bootstrap #54

Merged

Copilot started work on behalf of bcho March 17, 2026 00:58 View session

Address review feedback: use az CLI for tenant ID, move utility funct…

7dcbb3a

…ions to shared packages Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] [WIP] Address feedback on Azure profile-aware AKS Flex bootstrap fix~~ Refactor: use az account show for tenant ID; move kubeconfig/k8s helpers to shared packages Mar 17, 2026

Copilot AI requested a review from bcho March 17, 2026 01:09

Copilot finished work on behalf of bcho March 17, 2026 01:09

bcho requested changes Mar 17, 2026

View reviewed changes

Copilot started work on behalf of bcho March 17, 2026 01:19 View session

Use az CLI for subscription ID; fix indentation in APIServerFromKubec…

7fee6b5

…onfigFile Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI changed the title ~~Refactor: use az account show for tenant ID; move kubeconfig/k8s helpers to shared packages~~ Refactor: use az account show for tenant ID and subscription ID; move kubeconfig/k8s helpers to shared packages Mar 17, 2026

Copilot AI requested a review from bcho March 17, 2026 01:23

Copilot finished work on behalf of bcho March 17, 2026 01:23

bcho requested changes Mar 17, 2026

View reviewed changes

Copilot started work on behalf of bcho March 17, 2026 01:32 View session

Add contextName parameter to APIServerFromKubeconfigFile; pass contex…

1f10452

…t in cilium deploy Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI requested a review from bcho March 17, 2026 01:37

Copilot finished work on behalf of bcho March 17, 2026 01:37

bcho requested changes Mar 17, 2026

View reviewed changes

Copilot started work on behalf of bcho March 17, 2026 01:39 View session

Extract clusterContext variable in deployCilium; reuse across API ser…

217c0c3

…ver lookup and cilium install flags Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI requested a review from bcho March 17, 2026 01:42

Copilot finished work on behalf of bcho March 17, 2026 01:42

bcho approved these changes Mar 17, 2026

View reviewed changes

bcho marked this pull request as ready for review March 17, 2026 01:43

bcho merged commit 3cac673 into fix/node-bootstrap-script-held-packages Mar 17, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: use `az account show` for tenant ID and subscription ID; move kubeconfig/k8s helpers to shared packages#55

Refactor: use `az account show` for tenant ID and subscription ID; move kubeconfig/k8s helpers to shared packages#55
bcho merged 5 commits intofix/node-bootstrap-script-held-packagesfrom
copilot/sub-pr-54

Copilot AI commented Mar 17, 2026 •

edited

Loading

Uh oh!

bcho left a comment

Uh oh!

bcho Mar 17, 2026

Uh oh!

Copilot AI Mar 17, 2026

Uh oh!

bcho Mar 17, 2026

Uh oh!

Copilot AI Mar 17, 2026

Uh oh!

bcho left a comment

Uh oh!

bcho Mar 17, 2026

Uh oh!

Copilot AI Mar 17, 2026

Uh oh!

bcho Mar 17, 2026

Uh oh!

Copilot AI Mar 17, 2026

Uh oh!

bcho Mar 17, 2026

Uh oh!

Copilot AI Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcho left a comment

Choose a reason for hiding this comment

Uh oh!

bcho Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bcho Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bcho left a comment

Choose a reason for hiding this comment

Uh oh!

bcho Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bcho Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bcho Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Mar 17, 2026 •

edited

Loading