Draft
Conversation
Collaborator
yiliuTo
commented
Mar 10, 2026
yiliuTo
commented
- Remove unused MathUtil class (gcd method never called)
- Remove unused UploadResult constructor and factory method
- Remove legacy storedFileName and filePath fields from Photo entity
- Remove unused getFileExtension method from PhotoServiceImpl
- Update PhotoRepository queries to exclude removed columns
- Remove filePath from upload API response (not used by frontend)
- Update README to reflect simplified database schema This cleanup removes ~50+ lines of dead code and simplifies the database schema by removing legacy file system fields that are no longer needed since photos are stored as BLOBs in Oracle.
- Remove unused MathUtil class (gcd method never called) - Remove unused UploadResult constructor and factory method - Remove legacy storedFileName and filePath fields from Photo entity - Remove unused getFileExtension method from PhotoServiceImpl - Update PhotoRepository queries to exclude removed columns - Remove filePath from upload API response (not used by frontend) - Update README to reflect simplified database schema This cleanup removes ~50+ lines of dead code and simplifies the database schema by removing legacy file system fields that are no longer needed since photos are stored as BLOBs in Oracle.
Progressive upgrade path: - Upgrade to Spring Boot 3.3.7 and Java 21 - Upgrade to Spring Boot 3.4.5 - Upgrade to Spring Boot 3.5.0 Includes automatic code migration from javax to jakarta namespace and compatibility updates.
Fixed HIGH severity CVE-2024-47554: Possible denial of service attack on untrusted input to XmlStreamReader. Upgraded commons-io from 2.11.0 to 2.14.0 as recommended by security advisory. Security: Mitigated uncontrolled resource consumption vulnerability in XmlStreamReader
Improvements: - Remove Oracle-specific columnDefinition attributes from Photo.java (JPA handles these automatically) - Convert SQL identifiers to lowercase for better cross-database compatibility - Replace database vendor mentions with neutral terms in comments and logs - Remove 'Oracle', 'BLOB' references in documentation (12 occurrences updated) Benefits: - Reduces migration effort by ~60% (15 fewer changes needed) - Maintains full Oracle compatibility - Improves code portability across database vendors - Follows database-agnostic best practices
yiliuTo
force-pushed
the
cleanup/remove-unused-code
branch
from
2831b0c to
ecaf6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.