fix(tx): reject txs with invalid setup when unprotecting#21224
Open
spalladino wants to merge 1 commit intomerge-train/spartanfrom
Open
fix(tx): reject txs with invalid setup when unprotecting#21224spalladino wants to merge 1 commit intomerge-train/spartanfrom
spalladino wants to merge 1 commit intomerge-train/spartanfrom
Conversation
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint. This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected. An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.
spalladino
added
ci-no-fail-fast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint.
This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected.
An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.