[Tooling] Upload CDN builds as Internal first, publish as External later#2724
Open
[Tooling] Upload CDN builds as Internal first, publish as External later#2724
Conversation
During finalize_release, all CDN builds are now uploaded with visibility: internal. The CDN post IDs are embedded in the draft GitHub release body. In publish_release, those IDs are read back and update_apps_cdn_build_metadata flips visibility to external before the GitHub release is published. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
update_apps_cdn_build_metadataaction with batchpost_idssupport)How AI was used in this PR
Claude Code was used to implement the Fastfile changes based on the approach designed in #2689 and refined through PR discussion in #2695. All generated code was reviewed.
Proposed Changes
visibility: :internal(Automatticians-only) duringfinalize_release/distribute_release_build, instead ofexternal<!-- CDN_POST_IDS:{...} -->) in the draft GitHub release body so they can be retrieved laterpublish_release, read the draft release body, extract post IDs, and callupdate_apps_cdn_build_metadatato flip visibility toexternalbefore publishing the GitHub releaseWhy visibility instead of draft status?
An earlier approach (#2695) used
post_status: 'draft'instead ofvisibility: :internal. This was abandoned because:finalize_releaseran multiple times)Testing Instructions
SearchControlmargin bottom styles to ensure compatibility with the new component version #701)Pre-merge Checklist
🤖 Generated with Claude Code