Allow sort_by to be set when searching for events#53
Open
dNitza wants to merge 1 commit intoAutomattic:masterfrom
Open
Allow sort_by to be set when searching for events#53dNitza wants to merge 1 commit intoAutomattic:masterfrom
dNitza wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Contributor
|
@dNitza thanks for looking at this :) What state is it in? You mentioned that sorting options aren't lining up, is that still the case?.. A small note on first look, we'd also need We won't likely be looking at this again until January, so take your time if still interested, and feel free to close if not. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thanks for the plugin!
I was working on adding an event search integration and noticed that the plugin currently doesn't allow
sort_byto be set when making requests against the/events/search/endpoint, it just defaults todate.It also seems that the allowed sorting options don't match up to what is now available (which is something that probably changed with Eventbrite's 3rd version of the API — https://www.eventbrite.com.au/developer/v3/endpoints/events/#ebapi-get-events-search)
I've opened up a PR as a suggestion of how I'd see this working, but since the allowed sorting options don't quite match, those might need to be updated too.
Anyway, thanks again for the work on this plugin, it's much appreciated.