fix: Function mysqli_ping() is deprecated since 8.4 and no longer tries to reconnect since PHP 8.2

[macbre]

This PR resolves Deprecated: Function mysqli_ping() is deprecated since 8.4 warnings.

The change has been checked internally and works fine - the lost connection is detected, the re-connection takes place and the query is sent properly.

Resources

• https://www.php.net/manual/en/mysqli.ping.php
• https://php.watch/versions/8.2/mysqli-libmysql-no-longer-supported#mysqli-reconnect

[vnsavage]

This proposed change doesn't really implement everything that mysqli_ping() does, which we rely upon - Pings a server connection, or tries to reconnect if the connection has gone down - the reconnect, specifically.

[macbre]

Interesting, ex_mysql_error() also has four return statements, but SonarCube complains:

This method has 4 returns, which is more than the 3 allowed.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[aidvu]

Still thinking about this... @vnsavage wanted the reconnect logic here VS letting hyperdb just do its thing.

The reconnect was removed and wasn't working since at least 8.2. Considering that the fallback was good enough, not sure what value is there in having the reconnect re-implemented. In theory, it would be a bit faster then going through all of the logic for finding a server to connect to.

[aidvu]

Iliya had a good observation. If we get HYPERDB_SERVER_GONE_ERROR, we shouldn't try to ping, but go straight to disconnect():

HyperDB/db.php

Lines 1402 to 1407 in 2b329ab

	// MySQL server has gone away
	if ( isset( $this->dbhname_heartbeats[ $this->dbhname ]['last_errno'] ) &&
	HYPERDB_SERVER_GONE_ERROR == $this->dbhname_heartbeats[ $this->dbhname ]['last_errno'] ) {
	unset( $this->dbhname_heartbeats[ $this->dbhname ]['last_errno'] );
	return true;
	}

And I think with that, and some testing it's good to go.

[macbre]

@aidvu - like that?

[aidvu]

Nope. I don't think that's enough. It needs to behave the same way as this block:

HyperDB/db.php

Lines 523 to 532 in 8a51769

	if ( $this->should_mysql_ping() && ! $this->ex_mysql_ping( $this->dbhs[ $dbhname ] ) ) {
	if ( isset( $conn['disconnect (ping failed)'] ) ) {
	++$conn['disconnect (ping failed)'];
	} else {
	$conn['disconnect (ping failed)'] = 1;
	}
	$this->disconnect( $dbhname );
	break;
	}

So we either move the HYPERDB_SERVER_GONE_ERROR check there, or and disconnect/break for PHP < 8.0.0 or we rewrite the check a bit.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE