Add tests for /v1/oauth/authorize PKCE endpoint#696
Merged
rickyrombo merged 2 commits intomjp-oauth-endpointsfrom Mar 9, 2026
Merged
Add tests for /v1/oauth/authorize PKCE endpoint#696rickyrombo merged 2 commits intomjp-oauth-endpointsfrom
rickyrombo merged 2 commits intomjp-oauth-endpointsfrom
Conversation
Merged
…ion, invalid token, unknown client, write scope grant enforcement Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on adding OAuth 2.0 endpoints
Add tests for /v1/oauth/authorize PKCE endpoint
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/v1/oauth/authorizeendpoint (entry point to the PKCE flow) had no test coverage, leaving happy paths, validation logic, and grant enforcement untested.Changes
makeOAuthJWThelper: generates valid Ethereum personal-signed JWTs using a fixed test private key, replicating the exact signing format validated byvalidateOAuthJWTTokenToUserIdseedOAuthTestDataupdate: user 100's wallet updated to the address derived from the test private key, enabling real JWT verification against the DB in authorize testsPOST /v1/oauth/authorize:readscope andwritescope with an approved granttoken,client_id,redirect_uri,code_challenge,scope→400 invalid_requestcode_challenge_methodmust beS256→400 invalid_request400 invalid_request401 access_deniedclient_id→400 invalid_clientwritescope with no approved grant →403 access_denied🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.