Skip to content

Normalize write response shape, add blockhash, blocknumber#677

Merged
rickyrombo merged 1 commit intomainfrom
mjp-normalize-responses
Feb 27, 2026
Merged

Normalize write response shape, add blockhash, blocknumber#677
rickyrombo merged 1 commit intomainfrom
mjp-normalize-responses

Conversation

@rickyrombo
Copy link
Contributor

Removes erroneous "success" in write response, adds block hash and block number (matches client entity manager)

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeet

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does nothing care about the success bool?

@rickyrombo rickyrombo merged commit 9e75593 into main Feb 27, 2026
5 checks passed
@rickyrombo rickyrombo deleted the mjp-normalize-responses branch February 27, 2026 23:09
rickyrombo added a commit to AudiusProject/apps that referenced this pull request Mar 2, 2026
Regenerates the SDK following
AudiusProject/api#678 and
AudiusProject/api#677
- Removes `getPlaylistByHandleAndSlug` in favor of calling
`getBulkPlaylists` with permalink arg
- Updates return values of CommentsAPI to match other writes
- Updates embed player and client to use `getBulkPlaylists`
- Updates API and SDK docs

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants