audioreach-driver: fix gpr callback break after const ABI update#55
Merged
quic-aditrath merged 1 commit intoAudioReach:masterfrom Mar 9, 2026
Merged
Conversation
aiyapate
force-pushed
the
backward_comptibility_workaround
branch
from
b78f089 to
7c2e3d3
Compare
nandamajay
approved these changes
Mar 6, 2026
aiyapate
force-pushed
the
backward_comptibility_workaround
branch
3 times, most recently
from
c15f715 to
229c904
Compare
mohsRafi
approved these changes
Mar 9, 2026
nandamajay
approved these changes
Mar 9, 2026
aiyapate
force-pushed
the
backward_comptibility_workaround
branch
2 times, most recently
from
2c48fd1 to
e87e0d7
Compare
nandamajay
approved these changes
Mar 9, 2026
mohsRafi
approved these changes
Mar 9, 2026
aiyapate
force-pushed
the
backward_comptibility_workaround
branch
from
e87e0d7 to
bf3676f
Compare
Upstream changed the gpr_port_cb typedef in latest kernel to use 'const struct gpr_resp_pkt *'. Older kernels still use the mutable form. The audioreach-driver callbacks matched the old prototype and failed to compile against newer kernels. Introduce ar_kcompat.h and a wrapper macro that generates a kernel-facing callback with the correct prototype for the detected kernel version. The real implementation is moved to a const-correct core function. The driver no longer modifies the incoming GPR packet and instead updates a local copy when needed. This keeps the driver ABI-safe across all supported kernel versions. Signed-off-by: Aiyaz Patel <aiyapate@qti.qualcomm.com>
aiyapate
force-pushed
the
backward_comptibility_workaround
branch
from
bf3676f to
8c27790
Compare
quic-aditrath
approved these changes
Mar 9, 2026
nandamajay
approved these changes
Mar 9, 2026
qti-sbojja
approved these changes
Mar 9, 2026
mohsRafi
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changed the gpr_port_cb typedef in latest kernel to use 'const struct gpr_resp_pkt *'. Older kernels still use the mutable form. The audioreach-driver callbacks matched the old prototype and failed to compile against newer kernels.
Introduce ar_kcompat.h and a wrapper macro that generates a kernel-facing callback with the correct prototype for the detected kernel version. The real implementation is moved to a const-correct core function.
The driver no longer modifies the incoming GPR packet and instead updates a local copy when needed. This keeps the driver ABI-safe across all supported kernel versions.