audioreach-driver: Enable RPMsg packet driver#54
Open
quic-annemari wants to merge 1 commit intoAudioReach:masterfrom
Open
audioreach-driver: Enable RPMsg packet driver#54quic-annemari wants to merge 1 commit intoAudioReach:masterfrom
quic-annemari wants to merge 1 commit intoAudioReach:masterfrom
Conversation
Add new packet driver file q6apm_audio_pkt_rpmsg, which uses RPMsg as communication between HLOS and DSP. Also adds a feature flag that will disable hyp_assign for non-qcom devices. Signed-off-by: Annemarie Porter <annemari@qti.qualcomm.com>
quic-plai
reviewed
Mar 29, 2026
| audioreach_driver-objs += q6apm_audio_pkt.o | ||
| ccflags-y += -DQCOM_HYP_ASSIGN | ||
| else | ||
| audioreach_driver-objs += q6apm_audio_pkt_rpmsg.o |
Contributor
There was a problem hiding this comment.
Let's rename to audioreach_pkt_rpmsg
| #include <linux/uaccess.h> | ||
| #include <linux/termios.h> | ||
| #include <linux/wait.h> | ||
| #include "audioreach.h" |
Contributor
There was a problem hiding this comment.
double check if it is really necessary to include this header file
| #include <linux/termios.h> | ||
| #include <linux/wait.h> | ||
| #include "audioreach.h" | ||
| #include "q6prm_audioreach.h" |
Contributor
There was a problem hiding this comment.
double check if it is really necessary to include this header file
| // Copyright (c) 2020, Linaro Limited | ||
| // Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
|
|
||
| #include <dt-bindings/soc/qcom,gpr.h> |
Contributor
There was a problem hiding this comment.
I don't think we need to include this header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new packet driver file q6apm_audio_pkt_rpmsg, which uses RPMsg as communication between HLOS and DSP. Also adds a feature flag that will disable hyp_assign for non-qcom devices.