Conversation
ipapandinas
added
shiden
Dinonard
left a comment
Dinonard
left a comment
There was a problem hiding this comment.
Just a quick glance, LGTM overall
| OldTierThreshold::DynamicPercentage { percentage, .. } => { | ||
| TierThreshold::FixedPercentage { | ||
| required_percentage: *percentage, | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
This doesn't exist in live chains anymore though, right?
There was a problem hiding this comment.
Correct, it shouldn’t exist on current live chains. I kept the DynamicPercentage arm for historical-storage compatibility in the migration, so old state still upgrades safely if encountered.
|
/bench astar,shibuya,shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23336716016. |
|
/bench astar,shibuya,shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23348193204. |
|
/bench astar,shibuya all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23443949948. |
|
Benchmarks have been finished. |
|
/bench shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23453287853. |
|
/bench shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23498145389. |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23498145389. |
|
/bench shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23536786154. |
|
/bench shiden all |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23546388504. |
|
@ipapandinas it should be enough to bench dApp staking & inflation. For the rest, we can leave it for later (separate issue). |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/23546388504. |
|
Benchmarks have been finished. |
|
@Dinonard I managed to make the benchmark pass |
runtime/shibuya/src/lib.rs
Outdated
| >; | ||
|
|
||
| parameter_types! { | ||
| pub const DappStakingPruneMaxPeriod: u32 = 105; |
There was a problem hiding this comment.
This is very precise, but it would be better to give it a larger number, in case new periods start before you migrate.
You could put some hard limit, and read the actual number of values off the chain.
Hard limit ensures iteration is bounded, and reading the value off the chain ensures it's exactly what you need.
There was a problem hiding this comment.
Good suggestion but I’m preserving PeriodEnd for now (removed from the migration). It is tiny in storage and it is still use in rewards claiming. I will cleanup it in the following PR for #1589.
Minimum allowed line rate is |
2 participants
Pull Request Summary
This PR performs the following cleanups:
DynamicPercentagevariantslot_number_argsMaxNumberOfContractsLegacyconfig parameter