Skip to content

[PPSC-602] CWE-770: Unbounded .armisignore read #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shb7628 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PPSC-602] CWE-770: Unbounded .armisignore read #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/scan/repo/ignore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package repo

import (
"fmt"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -49,7 +50,19 @@ func LoadIgnorePatterns(repoRoot string) (*IgnoreMatcher, error) {
}, nil
}

// maxIgnoreFileSize is the maximum allowed size for .armisignore files (1MB).
// Ignore files are typically a few KB at most; anything larger is likely an error.
const maxIgnoreFileSize = 1 * 1024 * 1024

func loadIgnoreFile(ignoreFilePath, repoRoot string) ([]gitignore.Pattern, error) {
info, err := os.Stat(ignoreFilePath)
if err != nil {
return nil, err
}
if info.Size() > maxIgnoreFileSize {
return nil, fmt.Errorf(".armisignore file %s is too large (%d bytes, max %d)", ignoreFilePath, info.Size(), maxIgnoreFileSize)
}

data, err := os.ReadFile(ignoreFilePath) // #nosec G304 - ignore file path is constructed internally
if err != nil {
return nil, err
Expand Down
Loading