Skip to content

fix duplicates in campaign-status #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snukky merged 2 commits into from
Aug 6, 2025
Merged

fix duplicates in campaign-status #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2131d6f
attempt fix duplicate campaign-status
zouharvi Aug 6, 2025
5e71313
fix tests due to changing csv export
zouharvi Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Campaign/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def campaign_status_esa(campaign) -> str:
_data = DirectAssessmentDocumentResult.objects.filter(
createdBy=user, completed=True, task__campaign=campaign.id
)
_data_uniq_len = len({item.id for item in _data})
_data_uniq_len = len({(item.item.sourceID, item.item.targetID, item.item.itemType, item.item.id) for item in _data})

# If no data, show 0 progress or show that no task is assigned
if not _data:
Expand Down
2 changes: 1 addition & 1 deletion EvalData/models/direct_assessment_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ def get_system_data(
attributes_to_extract = (
'createdBy__username', # User ID
'item__targetID', # System ID
'item__itemID', # Segment ID
'item__sourceID', # Source ID
'item__itemType', # Item type
'item__metadata__market__sourceLanguageCode', # Source language
'item__metadata__market__targetLanguageCode', # Target language
Expand Down
10 changes: 5 additions & 5 deletions RegressionTests/tests/examples/example_mqmesa.scores.csv.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
engdeu0f01,ende-tutorial1,1000000,TGT,eng,deu,10,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial1,1000001,TGT,eng,deu,20,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial1,1000002,TGT,eng,deu,30,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial2,1000003,TGT,eng,deu,40,ende-tutorial2,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial2,1000004,TGT,eng,deu,50,ende-tutorial2,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial1,ende-tutorial1,TGT,eng,deu,10,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial1,ende-tutorial1,TGT,eng,deu,20,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial1,ende-tutorial1,TGT,eng,deu,30,ende-tutorial1,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial2,ende-tutorial2,TGT,eng,deu,40,ende-tutorial2,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
engdeu0f01,ende-tutorial2,ende-tutorial2,TGT,eng,deu,50,ende-tutorial2,False,"{'start_i': 0, 'end_i': 50, 'severity': 'major'}"
Loading
Loading