[campaign] update: admin to introduce an action to download the results#120
Closed
seblemaguer wants to merge 1 commit intoAppraiseDev:zouhar/admin-downloadfrom
Closed
[campaign] update: admin to introduce an action to download the results#120seblemaguer wants to merge 1 commit intoAppraiseDev:zouhar/admin-downloadfrom
seblemaguer wants to merge 1 commit intoAppraiseDev:zouhar/admin-downloadfrom
Conversation
Contributor
|
Hi, thanks! I don't think I can edit your PR directly, so I'll merge it into a working branch and then do a few edits and conflict resolutions there. |
Contributor
|
Actually there are too many conflicts, so I'll yank out your changes and sign you on the commit. |
Contributor
|
Superseeded by #215. |
Author
|
Thanks a lot for taking care of this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solves this #51.
For now this is a draft as I am a bit confused of why there are so many methods to download CSV files in the task/result definitions. I think some cleaning should potentially be done there.