Open
Conversation
BrandVersion no longer requires brand, and UserAgent safely skips browsers when the value is null instead of a list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_required([:brand])fromBrandVersion— SSPs send SUA with empty or missing brand strings (e.g."brand": "") which should not invalidate the entire bid request"browsers": nullinUserAgentchangeset —cast_embed(:browsers)raises on null forembeds_many, so we now skip the cast when browsers is not a listTest plan
"browsers": nulland"platform": {"brand": ""}🤖 Generated with Claude Code
Note
Low Risk
Small changes to Ecto changesets to tolerate malformed SUA input; low risk but could reduce validation strictness for
brandand skip browser casting when the payload is not a list.Overview
Relaxes V2 structured user-agent handling so malformed client-hint payloads don’t invalidate the whole bid request.
Specifically,
BrandVersionno longer requiresbrand, andUserAgentnow onlycast_embed(:browsers)when the incomingbrowsersvalue is a list (skippingnull/non-list values). Adds a regression test that ensures casting succeeds with"browsers": nulland an empty platformbrand.Written by Cursor Bugbot for commit a2f5d53. This will update automatically on new commits. Configure here.
Summary by cubic
Relaxed SUA validation so malformed fields no longer invalidate entire bid requests. Empty/missing platform brand and null browsers are now tolerated.
Written for commit a2f5d53. Summary will update on new commits.