Correctly handle usernames/passwords longer than 127 bytes#178
Open
anonym wants to merge 1 commit intoAnorov:masterfrom
Open
Correctly handle usernames/passwords longer than 127 bytes#178anonym wants to merge 1 commit intoAnorov:masterfrom
anonym wants to merge 1 commit intoAnorov:masterfrom
Conversation
chr() only works for lengths shorter than 128. For instance, for a 128 characters long username `chr(128).encode()` computes to `b'\xc2\x80'`, resulting in an invalid SOCKSv5 username/password request packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chr() only works for lengths shorter than 128. For instance, for a 128 characters long username
chr(128).encode()computes tob'\xc2\x80', resulting in an invalid SOCKSv5 username/password request packet.Fixes #177