Make search faster when there are a lot of songs#320
Open
AxelTerizaki wants to merge 1 commit intoAniDevTwitter:masterfrom
Open
Make search faster when there are a lot of songs#320AxelTerizaki wants to merge 1 commit intoAniDevTwitter:masterfrom
AxelTerizaki wants to merge 1 commit intoAniDevTwitter:masterfrom
Conversation
With a lot of songs (7000+) JS struggles to load the whole list, making the search much less pleasant to use. This patch includes : - Make search server-side and not client-side (with 7000 songs it's like a 3Mb file to load for the browser, it's painful especially on low-memory mobile devices) - Search also looks into song titles and artists, not just series name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of Karaoke Mugen's team's efforts to push back some of our changes to AO (and as a thanks for all the bugs fixed)
With a lot of songs (7000+) JS struggles to load the whole list, making
the search much less pleasant to use.
This patch includes :
a 3Mb file to load for the browser, it's painful especially on
low-memory mobile devices)
Beware though, this disables regexp search in the search field (we thought no one would really use it...)