🧪 Testing Improvement: Extract and test shell escaping logic#25
Open
giankpetrov wants to merge 6 commits intoAndrevops:mainfrom
Open
🧪 Testing Improvement: Extract and test shell escaping logic#25giankpetrov wants to merge 6 commits intoAndrevops:mainfrom
giankpetrov wants to merge 6 commits intoAndrevops:mainfrom
Conversation
…tor-validation-5599091117584387295 🧪 Add unit tests for GitExecutor path validation
Refactored `escapeForTerminal` in `src/utils/shell.ts` to extract the core logic into a pure function `escapeTextForShell` inside a new file `src/utils/shellEscape.ts`. This bypasses VS Code module loading errors in the native node test runner while allowing full test coverage. Added test coverage in `src/utils/shell.test.ts` for PowerShell, Windows CMD, and POSIX shell escaping logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract string shell escaping logic into a pure function escapeTextForShell without dependencies on vscode to allow testing it via the native Node.js test runner (node --experimental-strip-types --test) directly. Added testing for edge cases like PowerShell quotes, CMD escaping, and POSIX quotes.