Conversation
b97d90b to
9f7fbf9
Compare
9f7fbf9 to
165f4a5
Compare
We currently only calculate 360 different lines of sight with our azimuthal projection. This can potentially lead to a lack of coverage, especially in very long lines of sight. This adds a command line option --angle-subdivisions which allows for a user-configured angle subdivision to get coverage up to .01 of a degree
165f4a5 to
bc2e5fb
Compare
|
Another thing I thought, is there a simple smoke test for this? Like how much do the TVS and Longest Line unit tests change with more angles? And did you try making a heatmap PNG? We also need to update the viewshed code to be able to create viewsheds from increased angles. We can just make an issue for that. |
|
Just thought of something else: we're losing fidelity because the angle is stored as |
|
Before this ever gets merged we need #42 to be finalized and then we can decide how to add this on top of it. I agree that even a u16 would be better. I'm not sure if we want to use an I think the best option is to keep it as a |
We currently only calculate 360 different lines of sight with our azimuthal projection. This can potentially lead to a lack of coverage, especially in very long lines of sight. This adds a command line option --angle-subdivisions which allows for a user-configured angle subdivision to get coverage up to .01 of a degree