Fix numerous bugs involving the robot blocked array.#551
Draft
Fix numerous bugs involving the robot blocked array.#551
Conversation
Probably do not merge until 2.94 due to how sketchy this is. * The blocked array update flag is now cleared when the blocked array is updated (compatibility for 2.80 until 2.94). * The blocked array update flag is now set for DUPLICATE SELF XY and DUPLICATE SELF DIR (compatibility for 2.80 until 2.94). * SPITFIRE, SHOOTSEEKER, and SHOOTMISSILE now set the blocked array update flag instead of manually recalculating it (compatibility for 2.83 until 2.94). * IF DIR OF PLAYER now uses the player's blocked status instead of the current robot's (compatibility for 1.x until 2.94). * find_player() is no longer called in run_robot() unless the blocked array update flag is set. TODO: * Some kind of fix for SET/INC/DEC et al. changing the board but not setting update_blocked. * Changelog entries pre-2.94 if this gets merged before then. * Regression tests (several of them).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably do not merge until 2.94 due to how sketchy this is.
TODO:
SET/INC/DEC/SET RANDOM/INC RANDOM/DEC RANDOM/MULTIPLY/DIVIDE/MODULO/DOUBLE/HALFneed to setupdate_blockedif they write to a board counter.find_player()back into theupdate_blockedbranch for all version variants. This is probably true, but it's the most dangerous change in this patch.