Closed
Conversation
Collaborator
Author
|
Hm. Yeah, looks like they changed other things too. This change lets wasify download the release, but it still gets JS errors when it's running, e.g. tmpdir apparently no longer works: |
Collaborator
Author
|
Hm. Maybe the way to go would be to download version 2.3.0 (current as of a week ago) instead of 2.4.0 (current today, and broken.) Like, grab 2.3.0 instead of latest. |
Collaborator
Author
|
Closing in favour of #14. But something like this may be necessary in the long term regardless since there's a change in ruby-wasm naming conventions between 2.3.0 and 2.4.0+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it's "3.2" instead of "3_2" everywhere. This is a simple find/replace, so not sure this is 100% correct. It works better with scarpe-wasm, by which I mean it lets me get to the next bug, which isn't with wasify :-)