[transfers] Code generation: update services and models#461
[transfers] Code generation: update services and models#461AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated code generation updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains automated changes that introduce a few areas for improvement, primarily around string formatting for URL endpoints. The use of f-strings on static string segments is redundant. I've left comments suggesting a more idiomatic approach using a single f-string for URL construction, which enhances readability. The rest of the changes are formatting adjustments and appear to be in order.
| Use the `/grants` endpoint from the [Capital API](https://docs.adyen.com/api-explorer/capital/latest/get/grants) instead. | ||
| """ | ||
| endpoint = self.baseUrl + "/grants" | ||
| endpoint = self.baseUrl + f"/grants" |
There was a problem hiding this comment.
The use of an f-string for a static string "/grants" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/grants" | |
| endpoint = f"{self.baseUrl}/grants" |
| Use the `/grants` endpoint from the [Capital API](https://docs.adyen.com/api-explorer/capital/latest/post/grants) instead. | ||
| """ | ||
| endpoint = self.baseUrl + "/grants" | ||
| endpoint = self.baseUrl + f"/grants" |
There was a problem hiding this comment.
The use of an f-string for a static string "/grants" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/grants" | |
| endpoint = f"{self.baseUrl}/grants" |
| Get all transactions | ||
| """ | ||
| endpoint = self.baseUrl + "/transactions" | ||
| endpoint = self.baseUrl + f"/transactions" |
There was a problem hiding this comment.
The use of an f-string for a static string "/transactions" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/transactions" | |
| endpoint = f"{self.baseUrl}/transactions" |
| Approve initiated transfers | ||
| """ | ||
| endpoint = self.baseUrl + "/transfers/approve" | ||
| endpoint = self.baseUrl + f"/transfers/approve" |
There was a problem hiding this comment.
The use of an f-string for a static string "/transfers/approve" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/transfers/approve" | |
| endpoint = f"{self.baseUrl}/transfers/approve" |
| Cancel initiated transfers | ||
| """ | ||
| endpoint = self.baseUrl + "/transfers/cancel" | ||
| endpoint = self.baseUrl + f"/transfers/cancel" |
There was a problem hiding this comment.
The use of an f-string for a static string "/transfers/cancel" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/transfers/cancel" | |
| endpoint = f"{self.baseUrl}/transfers/cancel" |
| Get all transfers | ||
| """ | ||
| endpoint = self.baseUrl + "/transfers" | ||
| endpoint = self.baseUrl + f"/transfers" |
There was a problem hiding this comment.
The use of an f-string for a static string "/transfers" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/transfers" | |
| endpoint = f"{self.baseUrl}/transfers" |
| Transfer funds | ||
| """ | ||
| endpoint = self.baseUrl + "/transfers" | ||
| endpoint = self.baseUrl + f"/transfers" |
There was a problem hiding this comment.
The use of an f-string for a static string "/transfers" is unnecessary. It's more idiomatic and readable to construct the full URL with a single f-string.
| endpoint = self.baseUrl + f"/transfers" | |
| endpoint = f"{self.baseUrl}/transfers" |
1 participant
This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.